Changeset 108

Timestamp:

06/13/08 22:45:19 (5 months ago)

Author:

jweiss

Message:

fix #83 - colon in configuration parameter

Location:

trunk

Files:

• app/models/configuration_parameter.rb (modified) (1 diff)
• test/unit/configuration_parameter_test.rb (modified) (1 diff)

trunk/app/models/configuration_parameter.rb

@@ -11 +11 @@
   def validate
     self.errors.add('value', 'must be empty if prompt on deploy is set') if (self.prompt? && !self.value.blank?)
+    self.errors.add('name', 'can\'t contain a colon') if (!self.name.blank? && self.name.strip.starts_with?(":"))
   end
   

trunk/test/unit/configuration_parameter_test.rb

@@ -168 +168 @@
   end
   
+  def test_should_not_be_valid_when_name_starts_with_colon
+    c = @project.configuration_parameters.build(
+      :name => ':password_2', 
+      :value => 'abc',
+      :prompt_on_deploy => 0
+    )
+    c.valid?
+    assert_equal "can't contain a colon", c.errors.on(:name)
+  end
+
+  def test_should_not_be_valid_when_name_starts_with_spaces_and_colon
+    c = @project.configuration_parameters.build(
+      :name => '   :password_2', 
+      :value => 'abc',
+      :prompt_on_deploy => 0
+    )
+    c.valid?
+    assert_equal "can't contain a colon", c.errors.on(:name)
+  end
+  
 end